[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_d
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap |
Date: |
Mon, 10 Jul 2017 15:57:09 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jul 05, 2017 at 09:36:32PM +0800, Fam Zheng wrote:
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index 15fa602..4092669 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -381,6 +381,10 @@ struct BlockDriver {
> uint64_t parent_perm, uint64_t parent_shared,
> uint64_t *nperm, uint64_t *nshared);
>
> + /* Map and unmap a buffer for I/O, as a performance hint to the
> + * driver. */
> + void (*bdrv_dma_map)(BlockDriverState *bs, void *host, size_t size);
> + void (*bdrv_dma_unmap)(BlockDriverState *bs, void *host);
It's unclear what this API does and how to use it correctly. Please
flesh out the doc comments a bit to explain its use.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device, Fam Zheng, 2017/07/05
- [Qemu-devel] [PATCH v3 1/6] stubs: Add stubs for ram block API, Fam Zheng, 2017/07/05
- [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Fam Zheng, 2017/07/05
- Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Stefan Hajnoczi, 2017/07/10
- Re: [Qemu-devel] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Paolo Bonzini, 2017/07/10
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Stefan Hajnoczi, 2017/07/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Paolo Bonzini, 2017/07/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Fam Zheng, 2017/07/11
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Paolo Bonzini, 2017/07/12
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Stefan Hajnoczi, 2017/07/14
- Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap, Paolo Bonzini, 2017/07/14
[Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver, Fam Zheng, 2017/07/05