|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 17/22] tcg: distribute profiling counters across TCGContext's |
Date: | Sun, 9 Jul 2017 11:44:10 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/09/2017 11:14 AM, Emilio G. Cota wrote:
On Sun, Jul 09, 2017 at 10:45:55 -1000, Richard Henderson wrote:On 07/08/2017 09:50 PM, Emilio G. Cota wrote:+ /* includes aborted translations because of exceptions */ + atomic_set(&prof->tb_count1, prof->tb_count1 + 1);Again, atomic_set without atomic_read is pointless. Either you're trying to give the compiler extra information, or you aren't.See my comment to patch 3.
I still disagree. It's Just Plain Confusing.You'll continue to get questions like this from me and other reviewers in future. And it's not like avoiding atomic_read here makes anything faster. Both forms will compile to the same assembler.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |