qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 02/10] nbd/server: refactor nbd_negotiate


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 02/10] nbd/server: refactor nbd_negotiate
Date: Fri, 7 Jul 2017 10:42:09 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote:
> Combine two successive "if (oldStyle) {...} else {...}" into one.
> 
> Block "if (client->tlscreds)" under "if (oldStyle)" is unreachable,
> as we have "oldStyle = client->exp != NULL && !client->tlscreds;".
> So, delete this block.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  nbd/server.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]