[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 06/29] target/i386: [tcg] Refactor init_disa
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-devel] [PATCH v11 06/29] target/i386: [tcg] Refactor init_disas_context |
|
Date: |
Fri, 07 Jul 2017 09:41:30 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Emilio G Cota writes:
> On Wed, Jun 28, 2017 at 15:40:52 +0300, Lluís Vilanova wrote:
[,,,]
>> @@ -8425,7 +8415,7 @@ void gen_intermediate_code(CPUState *cpu,
>> TranslationBlock *tb)
>> dc-> code64 = (flags >> HF_CS64_SHIFT) & 1;
>> #endif
>> dc-> flags = flags;
>> - dc->jmp_opt = !(dc->tf || cpu->singlestep_enabled ||
>> + dc->jmp_opt = !(dc->tf || dc->base.singlestep_enabled ||
> Why this change and not leaving cpu->singlestep_enabled?
The single-stepping info is initialized by the generic code into dc->base, and
so I wanted to keep a bit more code consistency by unifying its use (on places I
touched). In fact, using dc->base ensures translation will be consistent even if
in the future cpu->singlestep_enabled is allowed to change.
Cheers,
Lluis