[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report() |
Date: |
Fri, 7 Jul 2017 08:33:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 07.07.2017 01:49, Alistair Francis wrote:
> Convert all uses of error_report("[Ww]arning:"... to use warn_report()
> instead. This helps standardise on a single method of printing warnings
> to the user.
>
> All of the warnings were found using this regex expression:
> error_report.*[Ww]arning:
> and replaced with:
> warn_report("
[...]
> diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c
> index 48e5b7315f..b25fe892ed 100644
> --- a/tests/test-qdev-global-props.c
> +++ b/tests/test-qdev-global-props.c
> @@ -232,10 +232,10 @@ static void test_dynamic_globalprop(void)
> g_test_trap_assert_passed();
> g_test_trap_assert_stderr_unmatched("*prop1*");
> g_test_trap_assert_stderr_unmatched("*prop2*");
> - g_test_trap_assert_stderr("*Warning: global dynamic-prop-type-bad.prop3
> has invalid class name\n*");
> + g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3
> has invalid class name\n*");
> g_test_trap_assert_stderr_unmatched("*prop4*");
> - g_test_trap_assert_stderr("*Warning: global nohotplug-type.prop5=105 not
> used\n*");
> - g_test_trap_assert_stderr("*Warning: global nondevice-type.prop6 has
> invalid class name\n*");
> + g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not
> used\n*");
> + g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has
> invalid class name\n*");
> g_test_trap_assert_stdout("");
> }
These changes are unrelated ... please drop them from your patch.
Thomas
- [Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages, (continued)
- Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(),
Thomas Huth <=
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Greg Kurz, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Cornelia Huck, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Eduardo Habkost, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Stefan Hajnoczi, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Marcel Apfelbaum, 2017/07/10