[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe de
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device |
Date: |
Thu, 6 Jul 2017 22:36:23 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, 07/06 16:22, Paolo Bonzini wrote:
>
>
> On 06/07/2017 16:06, address@hidden wrote:
> > ERROR: Use of volatile is usually wrong: see
> > Documentation/volatile-considered-harmful.txt
> > #843: FILE: block/nvme.c:40:
> > + volatile uint32_t *doorbell;
> >
> > ERROR: Use of volatile is usually wrong: see
> > Documentation/volatile-considered-harmful.txt
> > #869: FILE: block/nvme.c:66:
> > +typedef volatile struct {
>
> Indeed volatile should not be necessary, since we use memory barriers
> appropriately. But these are hardware registers (like, host hardware)
> so I guess it's okay for this special case.
I think I used it because we don't have ACCESS_ONCE (maybe we should?).
Fam
- Re: [Qemu-devel] [PATCH v3 4/6] block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap, (continued)
[Qemu-devel] [PATCH v3 5/6] qemu-img: Map bench buffer, Fam Zheng, 2017/07/05
[Qemu-devel] [PATCH v3 6/6] block: Move NVMe spec definitions to a separate header, Fam Zheng, 2017/07/05
Re: [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device, Paolo Bonzini, 2017/07/05
Re: [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device, no-reply, 2017/07/06