Re: [Qemu-devel] [PULL 00/42] Misc changes for 2017-07-05

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL 00/42] Misc changes for 2017-07-05

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c3f9992 target/i386: add the CONFIG_TCG into Makefiles
eb0d76c target/i386: add the tcg_enabled() in target/i386/
2a150b1 target/i386: move TLB refill function out of helper.c
b9806fe target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline
bc1daa7 target/i386: make cpu_get_fp80()/cpu_set_fp80() static
ad501c3 target/i386: move cpu_sync_bndcs_hflags() function
f2f5950 tcg: add the CONFIG_TCG into Makefiles
59d8d3f tcg: add CONFIG_TCG guards in headers
876e543 exec: elide calls to tb_lock and tb_unlock
42f9ee8 tcg: move tb_lock out of translate-all.h
532ebd4 tcg: add the tcg-stub.c file into accel/stubs/
e274546 vapic: use tcg_enabled
389a586 monitor: disable "info jit" and "info opcount" if !TCG
98fd2a3 tcg: make tcg_allowed global
3adf937 cpu: move interrupt handling out of translate-common.c
3a3e26a tcg: move page_size_init() function
edf2bfe vl: add tcg_enabled() for tcg related code
e5abc59 vl: convert -tb-size to qemu_strtoul
d89a54d configure: add --disable-tcg configure option
040e5c4 configure: early test for supported targets
0b2e1c3 configure: factor out list of supported Xen/KVM/HAX targets
a22fb4a qemu-doc: do not refer to years-old version numbers
fd51a47 qemu-thread: Assert locks are initialized before using
cb8211e virtio-scsi: finalize IOMMU support
c0f4097 checkpatch: should not use signal except for SIG_DFL or SIG_IGN
9b44c55 main_loop: Make main_loop_wait() return void
e0b1c11 tests/test-char.c: Don't use main_loop_wait()'s return value
5210dcc util/oslib-win32: Remove if conditional
b1dced3 xsave_helper: pull xsave and xrstor out of kvm.c into helper function
e33ba46 sockets: avoid formatting buffer that may not be NUL terminated
da10726 hw/misc/edu: Compile the edu device as common object
ff4bdc2 Makefile: Move bootdevice.o to common-obj-y
74acebf include/exec/poison: Mark CONFIG_SOFTMMU as poisoned
99fe965 cpu: Introduce a wrapper for tlb_flush() that can be used in common code
fd1a9a2 include/exec/poison: Mark CONFIG_KVM as poisoned, too
6775306 Move CONFIG_KVM related definitions to kvm_i386.h
1d3b268 include/exec/poison: Add some more missing TARGET and CONFIG defines
97fdb77 target/i386: simplify handling of conforming code segments on interrupt
ea5327e target/i386: fix interrupt CPL error when using ist in x86-64
04d53b9 nbd: fix NBD over TLS
2ae70f4 qemu-doc: Add missing "@c man end" statements
e274652 vcpu_dirty: share the same field in CPUState for all accelerators

=== OUTPUT BEGIN ===
Checking PATCH 1/42: vcpu_dirty: share the same field in CPUState for all 
accelerators...
Checking PATCH 2/42: qemu-doc: Add missing "@c man end" statements...
Checking PATCH 3/42: nbd: fix NBD over TLS...
Checking PATCH 4/42: target/i386: fix interrupt CPL error when using ist in 
x86-64...
Checking PATCH 5/42: target/i386: simplify handling of conforming code segments 
on interrupt...
Checking PATCH 6/42: include/exec/poison: Add some more missing TARGET and 
CONFIG defines...
Checking PATCH 7/42: Move CONFIG_KVM related definitions to kvm_i386.h...
Checking PATCH 8/42: include/exec/poison: Mark CONFIG_KVM as poisoned, too...
Checking PATCH 9/42: cpu: Introduce a wrapper for tlb_flush() that can be used 
in common code...
Checking PATCH 10/42: include/exec/poison: Mark CONFIG_SOFTMMU as poisoned...
Checking PATCH 11/42: Makefile: Move bootdevice.o to common-obj-y...
Checking PATCH 12/42: hw/misc/edu: Compile the edu device as common object...
Checking PATCH 13/42: sockets: avoid formatting buffer that may not be NUL 
terminated...
Checking PATCH 14/42: xsave_helper: pull xsave and xrstor out of kvm.c into 
helper function...
ERROR: spaces required around that '+' (ctx:VxV)
#214: FILE: target/i386/xsave_helper.c:47:
+        stq_p(xmm+8,   env->xmm_regs[i].ZMM_Q(1));
                  ^

ERROR: spaces required around that '+' (ctx:VxV)
#216: FILE: target/i386/xsave_helper.c:49:
+        stq_p(ymmh+8,  env->xmm_regs[i].ZMM_Q(3));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#218: FILE: target/i386/xsave_helper.c:51:
+        stq_p(zmmh+8,  env->xmm_regs[i].ZMM_Q(5));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#219: FILE: target/i386/xsave_helper.c:52:
+        stq_p(zmmh+16, env->xmm_regs[i].ZMM_Q(6));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#220: FILE: target/i386/xsave_helper.c:53:
+        stq_p(zmmh+24, env->xmm_regs[i].ZMM_Q(7));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#266: FILE: target/i386/xsave_helper.c:99:
+        env->xmm_regs[i].ZMM_Q(1) = ldq_p(xmm+8);
                                              ^

ERROR: spaces required around that '+' (ctx:VxV)
#268: FILE: target/i386/xsave_helper.c:101:
+        env->xmm_regs[i].ZMM_Q(3) = ldq_p(ymmh+8);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#270: FILE: target/i386/xsave_helper.c:103:
+        env->xmm_regs[i].ZMM_Q(5) = ldq_p(zmmh+8);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#271: FILE: target/i386/xsave_helper.c:104:
+        env->xmm_regs[i].ZMM_Q(6) = ldq_p(zmmh+16);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#272: FILE: target/i386/xsave_helper.c:105:
+        env->xmm_regs[i].ZMM_Q(7) = ldq_p(zmmh+24);
                                               ^

total: 10 errors, 0 warnings, 242 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/42: util/oslib-win32: Remove if conditional...
ERROR: spaces required around that '-' (ctx:VxV)
#32: FILE: util/oslib-win32.c:442:
+                handles[i-1] = handles[i];
                          ^

total: 1 errors, 0 warnings, 12 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/42: tests/test-char.c: Don't use main_loop_wait()'s return 
value...
Checking PATCH 17/42: main_loop: Make main_loop_wait() return void...
Checking PATCH 18/42: checkpatch: should not use signal except for SIG_DFL or 
SIG_IGN...
ERROR: line over 90 characters
#33: FILE: scripts/checkpatch.pl:2478:
+                       ERROR("use sigaction to establish signal handlers; 
signal is not portable\n" . $herecurr);

total: 1 errors, 0 warnings, 10 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/42: virtio-scsi: finalize IOMMU support...
Checking PATCH 20/42: qemu-thread: Assert locks are initialized before using...
Checking PATCH 21/42: qemu-doc: do not refer to years-old version numbers...
Checking PATCH 22/42: configure: factor out list of supported Xen/KVM/HAX 
targets...
Checking PATCH 23/42: configure: early test for supported targets...
Checking PATCH 24/42: configure: add --disable-tcg configure option...
Checking PATCH 25/42: vl: convert -tb-size to qemu_strtoul...
Checking PATCH 26/42: vl: add tcg_enabled() for tcg related code...
Checking PATCH 27/42: tcg: move page_size_init() function...
Checking PATCH 28/42: cpu: move interrupt handling out of translate-common.c...
Checking PATCH 29/42: tcg: make tcg_allowed global...
Checking PATCH 30/42: monitor: disable "info jit" and "info opcount" if !TCG...
Checking PATCH 31/42: vapic: use tcg_enabled...
Checking PATCH 32/42: tcg: add the tcg-stub.c file into accel/stubs/...
Checking PATCH 33/42: tcg: move tb_lock out of translate-all.h...
Checking PATCH 34/42: exec: elide calls to tb_lock and tb_unlock...
Checking PATCH 35/42: tcg: add CONFIG_TCG guards in headers...
Checking PATCH 36/42: tcg: add the CONFIG_TCG into Makefiles...
Checking PATCH 37/42: target/i386: move cpu_sync_bndcs_hflags() function...
Checking PATCH 38/42: target/i386: make cpu_get_fp80()/cpu_set_fp80() static...
Checking PATCH 39/42: target/i386: split cpu_set_mxcsr() and make 
cpu_set_fpuc() inline...
Checking PATCH 40/42: target/i386: move TLB refill function out of helper.c...
ERROR: braces {} are necessary for all arms of this statement
#91: FILE: target/i386/excp_helper.c:210:
+        if (env->hflags & HF_LMA_MASK) {
[...]
+        } else
[...]

WARNING: line over 80 characters
#139: FILE: target/i386/excp_helper.c:258:
+            pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) 
<< 3)) &

ERROR: braces {} are necessary for all arms of this statement
#343: FILE: target/i386/excp_helper.c:462:
+    if (is_user)
[...]

ERROR: braces {} are necessary for all arms of this statement
#345: FILE: target/i386/excp_helper.c:464:
+    if (is_write1 == 2 &&
[...]

total: 3 errors, 1 warnings, 696 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 41/42: target/i386: add the tcg_enabled() in target/i386/...
Checking PATCH 42/42: target/i386: add the CONFIG_TCG into Makefiles...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden