[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting |
Date: |
Thu, 6 Jul 2017 04:42:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05.07.2017 19:36, Alistair Francis wrote:
> This patch converts the existing error_vreport() function into a generic
> qmesg_vreport() function that takes an enum describing the
s/qmesg/qmsg/
> information to be reported.
>
> As part of this change a new qmesg_report() function is added as well with the
s/qmesg/qmsg/
> same capability.
>
> To maintain full compatibility the original error_report() function is
> maintained and no changes to the way errors are printed have been made.
> To improve access to the new informaiton and warning options wrapper functions
s/informaition/information/
> similar to error_report() have been added for warnings and information
> printing.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
> RFC V3:
> - Change the function and enum names to be more descriptive
> - Add wrapper functions for *_report() and *_vreport()
>
> include/qemu/error-report.h | 16 +++++++++
> scripts/checkpatch.pl | 8 ++++-
> util/qemu-error.c | 80
> +++++++++++++++++++++++++++++++++++++++++++--
> 3 files changed, 100 insertions(+), 4 deletions(-)
With the typos fixed:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [RFC v3 0/3] Implement a warning_report function, Alistair Francis, 2017/07/05
- [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Alistair Francis, 2017/07/05
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting,
Thomas Huth <=
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Daniel P. Berrange, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Daniel P. Berrange, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Daniel P. Berrange, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Alistair Francis, 2017/07/06
[Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information, Alistair Francis, 2017/07/05