Re: [Qemu-devel] [PATCH v2 2/6] nbd/server: use errp instead of LOG

[Paolo Bonzini]

On 05/07/2017 14:33, Vladimir Sementsov-Ogievskiy wrote:
> 
> 
>>> -static int GCC_FMT_ATTR(4, 5)
>>> +static int GCC_FMT_ATTR(5, 6)
>>>   nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type,
>>> -                           uint32_t opt, const char *fmt, ...)
>>> +                           uint32_t opt, Error **errp, const char
>>> *fmt, ...)
>>>   {
>> Markus, this violates our usual idiom of errp last in code that is not
>> directly operating on an Error (the actual Error implementation in
>> error.c being the main obvious exception that lists errp first), but I
>> don't see any better approach. Do you have any thoughts on it?

I think it's okay as it matches functions like vfprintf.

Paolo