[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earli
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earlier |
Date: |
Wed, 5 Jul 2017 16:21:21 +0800 |
Currently drive_init_func() may call migrate_get_current() while the
migrate object is still not ready yet at that time. Move the migration
object init earlier, along with the global properties, right after
acceleration init.
This fixes a breakage for iotest 055, which caused an assertion failure.
Reported-by: Max Reitz <address@hidden>
Reported-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Tested-by: QingFeng Hao <address@hidden>
Fixes: 3df663 ("migration: move only_migratable to MigrationState")
Signed-off-by: Peter Xu <address@hidden>
---
vl.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/vl.c b/vl.c
index 0c497a3..2ae4313 100644
--- a/vl.c
+++ b/vl.c
@@ -4414,6 +4414,18 @@ int main(int argc, char **argv, char **envp)
configure_accelerator(current_machine);
+ /*
+ * Register all the global properties, including accel properties,
+ * machine properties, and user-specified ones.
+ */
+ register_global_properties(current_machine);
+
+ /*
+ * Migration object can only be created after global properties
+ * are applied correctly.
+ */
+ migration_object_init();
+
if (qtest_chrdev) {
qtest_init(qtest_chrdev, qtest_log, &error_fatal);
}
@@ -4595,18 +4607,6 @@ int main(int argc, char **argv, char **envp)
exit (i == 1 ? 1 : 0);
}
- /*
- * Register all the global properties, including accel properties,
- * machine properties, and user-specified ones.
- */
- register_global_properties(current_machine);
-
- /*
- * Migration object can only be created after global properties
- * are applied correctly.
- */
- migration_object_init();
-
/* This checkpoint is required by replay to separate prior clock
reading from the other reads, because timer polling functions query
clock values from the log. */
--
2.7.4
- [Qemu-devel] [PATCH v2 0/4] migration: fix iotest 055, only-migratable break, Peter Xu, 2017/07/05
- [Qemu-devel] [PATCH v2 1/4] migration: fix handling for --only-migratable, Peter Xu, 2017/07/05
- [Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earlier,
Peter Xu <=
- [Qemu-devel] [PATCH v2 3/4] doc: add item for "-M enforce-config-section", Peter Xu, 2017/07/05
- [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section", Peter Xu, 2017/07/05
- Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section", Eduardo Habkost, 2017/07/06
- [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section", Peter Xu, 2017/07/06
- Re: [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section", Greg Kurz, 2017/07/07
- Re: [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section", Eduardo Habkost, 2017/07/07
- Re: [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section", Dr. David Alan Gilbert, 2017/07/07
- Re: [Qemu-devel] [PATCH v2.2 3/4] doc: add item for "-M enforce-config-section", Greg Kurz, 2017/07/10