[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework |
Date: |
Tue, 04 Jul 2017 20:59:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Richard Henderson writes:
> On 06/28/2017 05:32 AM, Lluís Vilanova wrote:
>> + void (*init_disas_context)(DisasContextBase *db, CPUState *cpu);
>> + void (*init_globals)(DisasContextBase *db, CPUState *cpu);
>> + void (*tb_start)(DisasContextBase *db, CPUState *cpu);
>> + void (*insn_start)(DisasContextBase *db, CPUState *cpu);
>> + BreakpointCheckType (*breakpoint_check)(DisasContextBase *db, CPUState
>> *cpu,
>> + const CPUBreakpoint *bp);
>> + target_ulong (*translate_insn)(DisasContextBase *db, CPUState *cpu);
>> + void (*tb_stop)(DisasContextBase *db, CPUState *cpu);
>> + void (*disas_log)(const DisasContextBase *db, CPUState *cpu);
> Any reason not to stuff the cpu pointer into the DisasContextBase instead of
> passing it around separately?
None, really. I'll move it from DisasContext (in targets where it's present)
into DisasContextBase, and use that one everywhere.
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
Thanks,
Lluis