[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qde
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev |
Date: |
Fri, 30 Jun 2017 04:18:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 2017-06-27 06:10, Peter Xu wrote:
> Let the old man "MigrationState" join the object family. Direct benefit
> is that we can start to use all the property features derived from
> current QDev, like: HW_COMPAT_* bits, command line setup for migration
> parameters (so will never need to set them up each time using HMP/QMP,
> this is really, really attractive for test writters), etc.
>
> I see no reason to disallow this happen yet. So let's start from this
> one, to see whether it would be anything good.
>
> Now we init the MigrationState struct statically in main() to make sure
> it's initialized after global properties are applied, since we'll use
> them during creation of the object.
>
> No functional change at all.
Evidently not quite right because this breaks iotest 055.
Condensed test case:
$ ./qemu-img create -f vmdk -o subformat=streamOptimized foo.vmdk 64M
Formatting 'foo.vmdk', fmt=vmdk size=67108864 compat6=off
hwversion=undefined subformat=streamOptimized
$ x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=foo.vmdk
qemu-system-x86_64: ./migration/migration.c:114: migrate_get_current:
Assertion `current_migration' failed.
[1] 15453 abort (core dumped) x86_64-softmmu/qemu-system-x86_64
-drive if=none,file=foo.vmdk
(It just worked before this patch.)
Max
> Reviewed-by: Juan Quintela <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> include/migration/misc.h | 1 +
> migration/migration.c | 78
> ++++++++++++++++++++++++++++++++++--------------
> migration/migration.h | 19 ++++++++++++
> vl.c | 6 ++++
> 4 files changed, 81 insertions(+), 23 deletions(-)
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 01/10] machine: export register_compat_prop(), (continued)
[Qemu-devel] [PATCH v6 02/10] accel: introduce AccelClass.global_props, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 03/10] vl: clean up global property registerations, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eduardo Habkost, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eduardo Habkost, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev,
Max Reitz <=
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/29
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eric Blake, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
[Qemu-devel] [PATCH v6 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/27