[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove ex
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE |
Date: |
Thu, 29 Jun 2017 14:32:00 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> Error is propagated to the caller, TRACE is not needed.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/nbd/common.c b/nbd/common.c
> index 6b5c1b7b02..4dab41e2c0 100644
> --- a/nbd/common.c
> +++ b/nbd/common.c
> @@ -97,9 +97,7 @@ void nbd_tls_handshake(QIOTask *task,
> {
> struct NBDTLSHandshakeData *data = opaque;
>
> - if (qio_task_propagate_error(task, &data->error)) {
> - TRACE("TLS failed %s", error_get_pretty(data->error));
> - }
> + qio_task_propagate_error(task, &data->error);
> data->complete = true;
> g_main_loop_quit(data->loop);
> }
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/6] nbd refactoring part 2, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE, Vladimir Sementsov-Ogievskiy, 2017/06/21
- Re: [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE,
Eric Blake <=
- [Qemu-devel] [PATCH v2 2/6] nbd/server: use errp instead of LOG, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 1/6] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply(), Vladimir Sementsov-Ogievskiy, 2017/06/21