Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

[Stefan Weil]

Am 29.06.2017 um 17:47 schrieb Paolo Bonzini:
> 
> 
> On 29/06/2017 17:46, Thomas Huth wrote:
>>> TCI is enabled only with a specific configure argument if your machine
>>> is not supported by TCG.  This would break _build_ configurations, not
>>> user configurations.  It's a remote possibility that users are building
>>> their own QEMU, with TCI enabled, to work around a TCG bug.  So we can
>>> be more speedy in removing the code.
>> You never know ... it's unlikely, but there might be people around who
>> run configure with "--enable-tcg-interpreter" on purpose.
> 
> And they have never reported a bug? :)  But I agree it's not a big deal.
>  Richard should decide.
> 
> Paolo

Was there a bug? I'm not aware of one.

The TODO assertions were added on purpose when I wrote the code:

Initially all TCG codes had it, and I removed them as soon as a
statement was executed and I had verified the result.

So the recently failing assertions are simply code which was
not triggered before, maybe because earlier versions of QEMU
did not use those cases or maybe because a new guest scenario
now needs them while my tests did not.

TCI was never meant to be used for production, so I think
my approach was acceptable.

Stefan