Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

[Laurent Vivier]

Le 28/06/2017 à 22:44, Khem Raj a écrit :
> The ucontext_t type had a tag struct ucontext until now
> but newer glibc will drop it so we need to adjust and use
> the exposed type instead
> 
> Signed-off-by: Khem Raj <address@hidden>
> Cc: Kamil Rytarowski <address@hidden>
> Cc: Riku Voipio <address@hidden>
> Cc: Laurent Vivier <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> ---
>  linux-user/host/aarch64/hostdep.h |  2 +-
>  linux-user/host/arm/hostdep.h     |  2 +-
>  linux-user/host/i386/hostdep.h    |  2 +-
>  linux-user/host/ppc64/hostdep.h   |  2 +-
>  linux-user/host/s390x/hostdep.h   |  2 +-
>  linux-user/host/x86_64/hostdep.h  |  2 +-
>  linux-user/signal.c               | 10 +++++-----
>  tests/tcg/test-i386.c             |  4 ++--
>  user-exec.c                       | 18 +++++++++---------
>  9 files changed, 22 insertions(+), 22 deletions(-)
> 
...
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 3d18d1b3ee..2c55a4f600 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -3346,7 +3346,7 @@ static void setup_rt_frame(int sig, struct 
> target_sigaction *ka,
>      *
>      *   a0 = signal number
>      *   a1 = pointer to siginfo_t
> -    *   a2 = pointer to struct ucontext
> +    *   a2 = pointer to ucontext_t
>      *
>      * $25 and PC point to the signal handler, $29 points to the
>      * struct sigframe.
> @@ -3733,7 +3733,7 @@ struct target_signal_frame {
>  
>  struct rt_signal_frame {
>      siginfo_t info;
> -    struct ucontext uc;
> +    ucontext_t uc;
>      uint32_t tramp[2];
>  };
>  
> @@ -3949,7 +3949,7 @@ struct rt_signal_frame {
>      siginfo_t *pinfo;
>      void *puc;
>      siginfo_t info;
> -    struct ucontext uc;
> +    ucontext_t uc;
>      uint16_t retcode[4];      /* Trampoline code. */
>  };
>  

I think these two rt_signal_frame are unused and can be removed.

Thanks,
Laurent