Re: [Qemu-devel] [RFC v1 0/3] Implement a warning_report function

[Daniel P. Berrange]

On Tue, Jun 27, 2017 at 01:45:41PM -0700, Alistair Francis wrote:
> QEMU currently has a standard method to report errors with
> error_repot(). This ensure a sane and standard format when printing
> errors. This series is attempting to add the same functionality for
> warnings.

I'm not seeing the obvious benefit in this change. Despite its name
'error_report' is ultimately just a clever way to run printf()
on a text string. It can be used for errors, warnings, information
alike. If anything the current method is simply misnamed, and could
be changed to 'message_report'.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|