Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Server cpu model

[Eduardo Habkost]

On Mon, Jun 26, 2017 at 09:23:00AM +0800, Boqun Feng wrote:
> On Fri, Jun 23, 2017 at 10:38:14AM -0300, Eduardo Habkost wrote:
> > On Wed, Jun 21, 2017 at 01:29:34PM +0800, Boqun Feng (Intel) wrote:
> > > Introduce Skylake-Server cpu mode which inherits the features from
> > > Skylake-Client and supports some additional features that are: AVX512,
> > > CWLB and PGPE1GB.
> > 
> > I will fix this to "CLWB" when applying the patch.
> > 
> 
> Oops.. thank you for pointing this out.
> 
[...]
> > 
> > I believe we should add the same comment about XSAVES from
> > Skylake-Cliente here, for consistency:
> > 
> >         /* Missing: XSAVES (not supported by some Linux versions,
> >          * including v4.1 to v4.6).
> >          * KVM doesn't yet expose any XSAVES state save component,
> >          * and the only one defined in Skylake (processor tracing)
> >          * probably will block migration anyway.
> >          */
> > 
> 
> Make sense.
> 
> > I can add it when applying the patch.
> > 
> 
> Please do, thanks! Or you prefer that I send out a V2 with typo fixed
> and comment added?

No need to send v2.  I have already queued the patch + fixes on my
x86-next queue.  Thanks.

-- 
Eduardo