qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 7/7] trace: [trivial] Statically enable all g


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH v8 7/7] trace: [trivial] Statically enable all guest events
Date: Mon, 26 Jun 2017 19:22:28 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Lluís Vilanova writes:

> Daniel P Berrange writes:
>> On Thu, Jun 08, 2017 at 10:25:22PM -0400, Emilio G. Cota wrote:
>>> From: Lluís Vilanova <address@hidden>
>>> 
>>> The optimizations of this series makes it feasible to have them
>>> available on all builds.

>> I'm not saying you're wrong, but where is the data to backup this
>> assertion ?

>> IMHO, this commit message should be describing how performance was
>> tested and what the results were.

> I can submit a new series with the performance measurements now that you've
> informally OK'ed Emilio's new patch.

> Is there some public script to automate that or do I have to cook my own?

BTW, I just realized that my original cover for v7 did include results:

  https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg02741.html

Do such numbers need to be in this commit or is the cover fine?


Thanks,
  Lluis




reply via email to

[Prev in Thread] Current Thread [Next in Thread]