Re: [Qemu-devel] [PATCH v9 09/20] qcow: convert QCow to use QCryptoBlock for encryption

[Daniel P. Berrange]

On Wed, Jun 21, 2017 at 04:29:02PM +0200, Max Reitz wrote:
> On 2017-06-19 19:34, Daniel P. Berrange wrote:
> > This converts the qcow driver to make use of the QCryptoBlock
> > APIs for encrypting image content. This is only wired up to
> > permit use of the legacy QCow encryption format. Users who wish
> > to have the strong LUKS format should switch to qcow2 instead.
> > 
> > With this change it is now required to use the QCryptoSecret
> > object for providing passwords, instead of the current block
> > password APIs / interactive prompting.
> > 
> >   $QEMU \
> >     -object secret,id=sec0,filename=/home/berrange/encrypted.pw \
> >     -drive file=/home/berrange/encrypted.qcow,encrypt.format=qcow,\
> 
> Still should be encrypt.format=aes, but, well... Let's just give it a

Opps, yes. Fixed that now for real.

> 
> Reviewed-by: Max Reitz <address@hidden>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|