Re: [Qemu-devel] [PATCH v2 1/4] qapi/qnull: Add own header

[Markus Armbruster]

Max Reitz <address@hidden> writes:

> On 2017-06-21 18:24, Markus Armbruster wrote:
>> Max Reitz <address@hidden> writes:
>> 
>>> Reviewed-by: Kevin Wolf <address@hidden>
>>> Signed-off-by: Max Reitz <address@hidden>
>>> ---
>>>  include/qapi/qmp/qnull.h   | 26 ++++++++++++++++++++++++++
>>>  include/qapi/qmp/qobject.h |  8 --------
>>>  include/qapi/qmp/types.h   |  1 +
>>>  qobject/qnull.c            |  1 +
>>>  target/i386/cpu.c          |  6 +-----
>>>  tests/check-qnull.c        |  2 +-
>>>  6 files changed, 30 insertions(+), 14 deletions(-)
>>>  create mode 100644 include/qapi/qmp/qnull.h
>>>
>>> diff --git a/include/qapi/qmp/qnull.h b/include/qapi/qmp/qnull.h
>>> new file mode 100644
>>> index 0000000..69555ac
>>> --- /dev/null
>>> +++ b/include/qapi/qmp/qnull.h
>>> @@ -0,0 +1,26 @@
>>> +/*
>>> + * QNull Module
>>> + *
>>> + * Copyright (C) 2009, 2017 Red Hat Inc.
>>> + *
>>> + * Authors:
>>> + *  Luiz Capitulino <address@hidden>
>>> + *
>>> + * This work is licensed under the terms of the GNU LGPL, version 2.1 or 
>>> later.
>>> + * See the COPYING.LIB file in the top-level directory.
>> 
>> Copy the boilerplate from qnull.c instead, factual correctness.
>
> Sorry, will do.

No need to be sorry!  Copying it from qobject.h along with the code was
the obvious thing to do.

[...]