Re: [Qemu-devel] [PATCH 4/5] memory: Add 'persistent' parameter to memory_region_init_ram_from_file()

[Eduardo Habkost]

On Thu, Jun 22, 2017 at 01:26:49PM +0100, Dr. David Alan Gilbert wrote:
> * Eduardo Habkost (address@hidden) wrote:
> > Make it possible to set the RAM_NONPERSISTENT flag on the RAMBlock when
> > mapping a file.
> > 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> 
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> 
> A little confusing having a persistent flag passed in but setting a
> NONPERSISTENT flag.
> 
> One thing to watch out for is the other effect, for example I think
> doing an MADV_REMOVE will zero the file;  if that's a ROM file that
> would probably be bad; but your description of persistent=false
> might make sense for a ROM file since it wont be changed.

Good point.  Sounds like a good idea to reword the documentation to
mentiuon that in addition to making data not written back, contents
might be destroyed.

-- 
Eduardo