Re: [Qemu-devel] [PATCH 11/15] tcg: split cpu_set_mxcsr()/cpu_set_fpuc()

[Richard Henderson]

On 06/21/2017 03:19 AM, Yang Zhong wrote:
> Split the cpu_set_mxcsr()/cpu_set_fpuc() with specific tcg code.
> tcg_update_mxcsr()/tcg_set_fpuc() need be implemented in tcg-stub.c
> file if tcg is disabled.
>
> Signed-off-by: Yang Zhong <address@hidden>
> ---
>   accel/stubs/tcg-stub.c   |  8 ++++++++
>   target/i386/cpu.h        | 15 +++++++++++++--
>   target/i386/fpu_helper.c |  8 +++-----
>   3 files changed, 24 insertions(+), 7 deletions(-)
>
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index dafb1d0..91625a8 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -75,6 +75,14 @@ void dump_opcount_info(FILE *f, fprintf_function cpu_fprintf)
>   {
>   }
>   
> +void tcg_update_mxcsr(CPUX86State *env)
> +{
> +}
> +
> +void tcg_set_fpuc(CPUX86State *env)
> +{
> +}

Do not put x86-specific functions in what is clearly a target-independent file.
Paolo gave you one way of doing that for this case.


r~