[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/dis
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests |
Date: |
Sat, 17 Jun 2017 09:06:32 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.3 |
Philippe Mathieu-Daudé <address@hidden> writes:
> having the command to run in the variable make scripts harder to
> manage.
I'm not sure this adds much over the TEST_CMD not set == don't run we
had before.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>
> using 0/1 or no/yes is pretty much the same.
>
> .travis.yml | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index b2c69fdd59..c9ac741afc 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -46,7 +46,7 @@ notifications:
> env:
> global:
> - PARALLEL_JOBS="$(($(getconf _NPROCESSORS_ONLN) + 1))"
> - - TEST_CMD="make check"
> + - RUN_TESTS="yes"
> matrix:
> - CONFIG=""
> - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
> @@ -66,7 +66,7 @@ before_script:
> - ./configure ${CONFIG}
> script:
> - make -j${PARALLEL_JOBS}
> - - test -z "${TEST_CMD}" || ${TEST_CMD}
> + - if [ "${RUN_TESTS}" == "yes" ]; then make check; fi
> matrix:
> include:
> # Test with CLang for compile portability
> @@ -77,16 +77,16 @@ matrix:
> compiler: gcc
> # We manually include builds which we disable "make check" for
> - env: CONFIG="--enable-debug --enable-tcg-interpreter"
> - TEST_CMD=""
> + RUN_TESTS="no"
> compiler: gcc
> - env: CONFIG="--enable-trace-backends=simple"
> - TEST_CMD=""
> + RUN_TESTS="no"
> compiler: gcc
> - env: CONFIG="--enable-trace-backends=ftrace"
> - TEST_CMD=""
> + RUN_TESTS="no"
> compiler: gcc
> - env: CONFIG="--enable-trace-backends=ust"
> - TEST_CMD=""
> + RUN_TESTS="no"
> compiler: gcc
> - env: CONFIG=""
> os: osx
> @@ -191,6 +191,6 @@ matrix:
> env:
> - COMPILER_NAME=gcc CXX=g++-5 CC=gcc-5
> - CONFIG="--cc=gcc-5 --cxx=g++-5 --disable-pie --disable-linux-user"
> - - TEST_CMD=""
> + - RUN_TESTS="no"
> before_script:
> - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread
> -fuse-ld=gold" || cat config.log
--
Alex Bennée
- [Qemu-devel] [PATCH 00/11] travis: try to reduce failures, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 01/11] travis: build using all available cpus, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 02/11] travis: split building/testing to have finer elapsed time, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests, Philippe Mathieu-Daudé, 2017/06/16
- Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests,
Alex Bennée <=
- [Qemu-devel] [PATCH 04/11] tests: add rule to compile many objects used by tests, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 06/11] travis: retry if llvm.org timeouts, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 05/11] travis: build tests objects in parallel, then run tests sequentially, Philippe Mathieu-Daudé, 2017/06/16
- [Qemu-devel] [PATCH 07/11] travis: install more library dependencies, Philippe Mathieu-Daudé, 2017/06/16