qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Exit after enabling interru


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Exit after enabling interrupts
Date: Thu, 15 Jun 2017 14:29:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 06/15/2017 02:19 PM, Aurelien Jarno wrote:
While the above looks correct, it's not complete. It only fixes the
microMIPS EI instruction. The MIPS one also has to be fixed.

For what I understood, anything that can change the result of
cpu_mips_hw_interrupts_enabled has to stop the translation. In that case
I checked that ERET/ERETNC and MTC0/DMTC0 to the Status register are
already correct, that said it might be a good idea to update the
comments to mention it.

I can work on a better patch, but I doubt I'll have time before the
week-end.

Ok, I'll drop this one for now.  It's not urgent.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]