[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] target/arm: Exit after clearing interrup
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] target/arm: Exit after clearing interrupt mask |
Date: |
Thu, 15 Jun 2017 09:30:44 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.3 |
Richard Henderson <address@hidden> writes:
> Exit to cpu loop so we reevaluate cpu_arm_hw_interrupts.
>
> Cc: address@hidden
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
> ---
> target/arm/translate-a64.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 860e279..e55547d 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -1422,7 +1422,9 @@ static void handle_msr_i(DisasContext *s, uint32_t insn,
> gen_helper_msr_i_pstate(cpu_env, tcg_op, tcg_imm);
> tcg_temp_free_i32(tcg_imm);
> tcg_temp_free_i32(tcg_op);
> - s->is_jmp = DISAS_UPDATE;
> + /* For DAIFClear, exit the cpu loop to re-evaluate pending IRQs. */
> + gen_a64_set_pc_im(s->pc);
> + s->is_jmp = (op == 0x1f ? DISAS_EXIT : DISAS_JUMP);
> break;
> }
> default:
> @@ -11369,6 +11371,9 @@ void gen_intermediate_code_a64(ARMCPU *cpu,
> TranslationBlock *tb)
> case DISAS_JUMP:
> tcg_gen_lookup_and_goto_ptr(cpu_pc);
> break;
> + case DISAS_EXIT:
> + tcg_gen_exit_tb(0);
> + break;
> case DISAS_TB_JUMP:
> case DISAS_EXC:
> case DISAS_SWI:
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v2 2/5] target/alpha: Use tcg_gen_lookup_and_goto_ptr, (continued)
[Qemu-devel] [PATCH v2 4/5] target/s390x: Exit after changing PSW mask, Richard Henderson, 2017/06/14
[Qemu-devel] [PATCH v2 5/5] target/arm: Exit after clearing interrupt mask, Richard Henderson, 2017/06/14
Re: [Qemu-devel] [PATCH v2 5/5] target/arm: Exit after clearing interrupt mask,
Alex Bennée <=
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for TCG hangs, no-reply, 2017/06/14
Re: [Qemu-devel] [PATCH v2 0/5] Fixes for TCG hangs, no-reply, 2017/06/14