[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/14] migration: Don't try to set *errp directly
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 02/14] migration: Don't try to set *errp directly |
Date: |
Tue, 13 Jun 2017 11:51:08 +0200 |
From: Eduardo Habkost <address@hidden>
Assigning directly to *errp is not valid, as errp may be NULL,
&error_fatal, or &error_abort. Use error_propagate() instead.
Cc: Juan Quintela <address@hidden>
Cc: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 9dfa19a..ae087df 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1179,7 +1179,7 @@ bool migration_is_blocked(Error **errp)
}
if (migration_blockers) {
- *errp = error_copy(migration_blockers->data);
+ error_propagate(errp, error_copy(migration_blockers->data));
return true;
}
--
2.9.4
- [Qemu-devel] [PULL 00/14] Migration PULL request, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 01/14] migration: isolate return path on src, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 03/14] ram: Print block stats also in the complete case, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 04/14] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 05/14] migration: Remove MigrationState from migration_channel_incomming(), Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 02/14] migration: Don't try to set *errp directly,
Juan Quintela <=
- [Qemu-devel] [PULL 07/14] migration: Split registration functions from vmstate.h, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 08/14] migration: Move dump_vmsate_json_to_file() to misc.h, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 06/14] migration: Move self_announce_delay() to misc.h, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 09/14] migration: Move constants to savevm.h, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 10/14] migration: Commands are only used inside migration.c, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 11/14] migration: ram_control_* are implemented in qemu_file, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 12/14] migration: create global_state.c, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 13/14] migration: Move remaining exported functions to migration/misc.h, Juan Quintela, 2017/06/13
- [Qemu-devel] [PULL 14/14] migration: Move migration.h to migration/, Juan Quintela, 2017/06/13
- Re: [Qemu-devel] [PULL 00/14] Migration PULL request, Peter Maydell, 2017/06/13