[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_dev
From: |
Auger Eric |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access |
Date: |
Mon, 12 Jun 2017 21:14:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Juan,
On 12/06/2017 08:23, Juan Quintela wrote:
> Eric Auger <address@hidden> wrote:
>> In some circumstances, we don't want to abort if the
>> kvm_device_access fails. This will be the case during ITS
>> migration, in case the ITS table save/restore fails because
>> the guest did not program the vITS correctly. So let's pass an
>> error object to the function and return the ioctl value. New
>> callers will be able to make a decision upon this returned
>> value.
>>
>> Existing callers pass &error_abort which will cause the
>> function to abort on failure.
>>
>> Signed-off-by: Eric Auger <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
Thank you for the review!
Eric
>
- [Qemu-devel] [PATCH v6 0/4] vITS save/restore, Eric Auger, 2017/06/09
- [Qemu-devel] [PATCH v6 1/4] kvm-all: Pass an error object to kvm_device_access, Eric Auger, 2017/06/09
- [Qemu-devel] [PATCH v6 3/4] hw/intc/arm_gicv3_kvm: Implement pending table save, Eric Auger, 2017/06/09
- [Qemu-devel] [PATCH v6 2/4] hw/intc/arm_gicv3_its: Implement state save/restore, Eric Auger, 2017/06/09
- [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Allow save/restore, Eric Auger, 2017/06/09
- Re: [Qemu-devel] [PATCH v6 0/4] vITS save/restore, Peter Maydell, 2017/06/13