Re: [Qemu-devel] [PATCH v3 19/43] qdev: use appropriate getter/setters type

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Based on the underlying type of the data accessed, use the appropriate
> getters/setters.

Enumerating data here would be nice.

* AcpiPmInfo members s3_disabled, s4_disabled are bool, member s4_val is
  an uint8_t.

* Property ACPI_PCIHP_IO_PROP is defined with
  object_property_add_uint32_ptr().

* Property PCIE_HOST_MCFG_SIZE is implemented with visit_type_uint64()

* PCIDevice property "addr" is backed by PCIDevice member devfn, which
  is an int32_t.

> Signed-off-by: Marc-André Lureau <address@hidden>

Preferably with a more detailed commit message:
Reviewed-by: Markus Armbruster <address@hidden>