[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] migration: Don't try to set *errp directly
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] migration: Don't try to set *errp directly |
Date: |
Thu, 8 Jun 2017 15:21:41 +0100 |
User-agent: |
Mutt/1.8.2 (2017-04-18) |
* Eduardo Habkost (address@hidden) wrote:
> Assigning directly to *errp is not valid, as errp may be NULL,
> &error_fatal, or &error_abort. Use error_propagate() instead.
>
> Cc: Juan Quintela <address@hidden>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 48c94c9ca1..5a8bef3ef5 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1188,7 +1188,7 @@ bool migration_is_blocked(Error **errp)
> }
>
> if (migration_blockers) {
> - *errp = error_copy(migration_blockers->data);
> + error_propagate(errp, error_copy(migration_blockers->data));
> return true;
> }
if errp is NULL doesn't that leak the error_copy ?
Dave
>
> --
> 2.11.0.259.g40922b1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes, Eduardo Habkost, 2017/06/08
- [Qemu-devel] [PATCH 1/5] xilinx: Fix error handling, Eduardo Habkost, 2017/06/08
- [Qemu-devel] [PATCH 3/5] websock: Don't try to set *errp directly, Eduardo Habkost, 2017/06/08
- [Qemu-devel] [PATCH 4/5] migration: Don't try to set *errp directly, Eduardo Habkost, 2017/06/08
- [Qemu-devel] [PATCH 2/5] block: Don't try to set *errp directly, Eduardo Habkost, 2017/06/08
- [Qemu-devel] [PATCH 5/5] vnc: No need for Error** parameter at vnc_client_io_error(), Eduardo Habkost, 2017/06/08
Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes, Eric Blake, 2017/06/08