[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 02/43] object: fix potential leak in getters
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 02/43] object: fix potential leak in getters |
Date: |
Wed, 7 Jun 2017 20:35:54 +0400 |
If the property is not of the requested type, the getters will leak a
QObject.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
qom/object.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index eb4bc924ff..c7b8079df6 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1122,7 +1122,7 @@ char *object_property_get_str(Object *obj, const char
*name,
retval = g_strdup(qstring_get_str(qstring));
}
- QDECREF(qstring);
+ qobject_decref(ret);
return retval;
}
@@ -1183,7 +1183,7 @@ bool object_property_get_bool(Object *obj, const char
*name,
retval = qbool_get_bool(qbool);
}
- QDECREF(qbool);
+ qobject_decref(ret);
return retval;
}
@@ -1214,7 +1214,7 @@ int64_t object_property_get_int(Object *obj, const char
*name,
retval = qint_get_int(qint);
}
- QDECREF(qint);
+ qobject_decref(ret);
return retval;
}
--
2.13.0.91.g00982b8dd
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 01/43] qdev: remove PropertyInfo.qtype field, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 02/43] object: fix potential leak in getters,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 03/43] tests: Remove test cases for alternates of 'number' and 'int', Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 04/43] tests: add more int/number ranges checks, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 07/43] qapi: Remove visit_start_alternate() parameter promote_int, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 06/43] qapi: merge QInt and QFloat in QNum, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 08/43] tests: remove /{qnum, qlist, dict}/destroy test, Marc-André Lureau, 2017/06/07