[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 19/22] ide-test: check return of fwrite
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 19/22] ide-test: check return of fwrite |
Date: |
Sun, 4 Jun 2017 18:45:23 +0300 |
From: John Snow <address@hidden>
To quiet patchew, add an assert for fwrite's return value.
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
tests/ide-test.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/ide-test.c b/tests/ide-test.c
index 139ebc0ec6..bfd79ddbdc 100644
--- a/tests/ide-test.c
+++ b/tests/ide-test.c
@@ -796,11 +796,13 @@ static void cdrom_pio_impl(int nblocks)
int i, j;
uint8_t data;
uint16_t limit;
+ size_t ret;
/* Prepopulate the CDROM with an interesting pattern */
generate_pattern(pattern, patt_len, ATAPI_BLOCK_SIZE);
fh = fopen(tmp_path, "w+");
- fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh);
+ ret = fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh);
+ g_assert_cmpint(ret, ==, patt_blocks);
fclose(fh);
ide_test_start("-drive
if=none,file=%s,media=cdrom,format=raw,id=sr0,index=0 "
@@ -880,6 +882,7 @@ static void test_cdrom_pio_large(void)
static void test_cdrom_dma(void)
{
static const size_t len = ATAPI_BLOCK_SIZE;
+ size_t ret;
char *pattern = g_malloc(ATAPI_BLOCK_SIZE * 16);
char *rx = g_malloc0(len);
uintptr_t guest_buf;
@@ -896,7 +899,8 @@ static void test_cdrom_dma(void)
generate_pattern(pattern, ATAPI_BLOCK_SIZE * 16, ATAPI_BLOCK_SIZE);
fh = fopen(tmp_path, "w+");
- fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh);
+ ret = fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh);
+ g_assert_cmpint(ret, ==, 16);
fclose(fh);
send_dma_request(CMD_PACKET, 0, 1, prdt, 1, send_scsi_cdb_read10);
--
2.11.0
- [Qemu-devel] [PULL 02/22] qemu-doc: Add hyperlinks to further license information, (continued)
- [Qemu-devel] [PULL 02/22] qemu-doc: Add hyperlinks to further license information, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 08/22] trivial: Remove unneeded ifndef in memory.h, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 10/22] target/arm: add data cache invalidation cp15 instruction to cortex-r5, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 07/22] altera_timer: fix incorrect memset, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 05/22] tests/libqtest: Print error instead of aborting when env variable is missing, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 22/22] hw/core: nmi.c can be compiled as common-obj nowadays, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 11/22] hw/xtensa: sim: use g_string/g_new, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 14/22] hw/mips: add missing include, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 01/22] qemu-doc: Move the qemu-ga description into a separate chapter, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 17/22] qemu-ga: remove useless allocation, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 19/22] ide-test: check return of fwrite,
Michael Tokarev <=
- [Qemu-devel] [PULL 15/22] qapi: Fix some QMP documentation regressions, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 18/22] help: Add newline to end of thread option help text, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 04/22] docs/qdev-device-use.txt: update section Default Devices, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 13/22] register: display register prefix (name) since it is available, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 20/22] dump: fix memory_mapping_filter leak, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 03/22] docs qemu-doc: Avoid ide-drive, it's deprecated, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 16/22] scsi/lsi53c895a: Remove unused lsi_mem_*() return value, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 12/22] hw/sparc: use ARRAY_SIZE() macro, Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 06/22] configure: Detect native NetBSD curses(3), Michael Tokarev, 2017/06/04
- [Qemu-devel] [PULL 21/22] ivshmem-server: ivshmem-client: Build when eventfd() is available, Michael Tokarev, 2017/06/04