[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/15] blkdebug: support BDRV_REQ_ALLOCATE
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/15] blkdebug: support BDRV_REQ_ALLOCATE |
Date: |
Thu, 1 Jun 2017 14:50:56 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/01/2017 10:14 AM, Anton Nefedov wrote:
> Support the flag if the underlying BDS supports it
>
> Signed-off-by: Anton Nefedov <address@hidden>
> ---
> block/blkdebug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Shouldn't other passthrough drivers (like raw-format.c) make this change
as well?
>
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index a5196e8..8b1401b 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -415,7 +415,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict
> *options, int flags,
>
> bs->supported_write_flags = BDRV_REQ_FUA &
> bs->file->bs->supported_write_flags;
> - bs->supported_zero_flags = (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP) &
> + bs->supported_zero_flags =
> + (BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_ALLOCATE) &
> bs->file->bs->supported_zero_flags;
> ret = -EINVAL;
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 02/15] file-posix: support BDRV_REQ_ALLOCATE, (continued)
[Qemu-devel] [PATCH v2 01/15] block: introduce BDRV_REQ_ALLOCATE flag, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 04/15] qcow2: alloc space for COW in one chunk, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 05/15] qcow2: do not COW the empty areas, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 03/15] blkdebug: support BDRV_REQ_ALLOCATE, Anton Nefedov, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 03/15] blkdebug: support BDRV_REQ_ALLOCATE,
Eric Blake <=
[Qemu-devel] [PATCH v2 07/15] qcow2: set inactive flag, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 10/15] qcow2: handle_prealloc(): find out if area zeroed by earlier preallocation, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 06/15] qcow2: preallocation at image expand, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 08/15] qcow2: truncate preallocated space, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 09/15] qcow2: check space leak at the end of the image, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 11/15] qcow2: fix misleading comment about L2 linking, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 12/15] qcow2-cluster: slightly refactor handle_dependencies(), Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 13/15] qcow2-cluster: make handle_dependencies() logic easier to follow, Anton Nefedov, 2017/06/01
[Qemu-devel] [PATCH v2 15/15] iotest 046: test simultaneous cluster write error case, Anton Nefedov, 2017/06/01