[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure |
Date: |
Thu, 1 Jun 2017 13:18:37 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/01/2017 01:06 PM, Laszlo Ersek wrote:
> On 06/01/17 15:03, Marc-André Lureau wrote:
>> One way or another, the guest could communicate various dump info (via
>> guest agent or vmcoreinfo device) and populate that structure. It can
>> then be used to augment the dump with various details, as done in the
>> following patch.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>> include/sysemu/dump-info.h | 18 ++++++++++++++++++
>> dump.c | 3 +++
>> 2 files changed, 21 insertions(+)
>> create mode 100644 include/sysemu/dump-info.h
>>
>> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-info.h
>> new file mode 100644
>> index 0000000000..d2378e15e2
>> --- /dev/null
>> +++ b/include/sysemu/dump-info.h
>> @@ -0,0 +1,18 @@
>> +#ifndef DUMP_INFO_H
>> +#define DUMP_INFO_H
>>
>
> Can you please spell out, in the commit message, the reason for
> introducing a new header file? (I suspect your reason, but it should be
> documented explicitly.)
Also, should you have a copyright header in the new file? And does
MAINTAINERS cover it?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/4] dump: add vmcoreinfo note, Marc-André Lureau, 2017/06/01
- [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Zhang Chen, 2017/06/04
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/06
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Andrew Jones, 2017/06/05
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Peter Xu, 2017/06/05
[Qemu-devel] [PATCH v2 2/4] dump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/06/01