[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 06/13] test-char: unref chardev-udp after tes
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 06/13] test-char: unref chardev-udp after test |
Date: |
Wed, 31 May 2017 19:22:10 +0000 |
On Tue, May 30, 2017 at 6:06 PM Anton Nefedov <address@hidden>
wrote:
> this is only not a problem if the test is last in a suite,
> otherwise it makes the following main_loop() calls to fail
>
> Signed-off-by: Anton Nefedov <address@hidden>
>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> tests/test-char.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/test-char.c b/tests/test-char.c
> index f3b377f..d63d3d2 100644
> --- a/tests/test-char.c
> +++ b/tests/test-char.c
> @@ -456,6 +456,8 @@ static void char_udp_test(void)
>
> close(sock);
> g_free(tmp);
> + qemu_chr_fe_deinit(&be);
> + object_unparent(OBJECT(chr));
> }
>
> static void char_file_test(void)
> --
> 2.7.4
>
>
> --
Marc-André Lureau
- [Qemu-devel] [PATCH v3 01/13] char: move QemuOpts->ChardevBackend translation to a separate func, (continued)
- [Qemu-devel] [PATCH v3 01/13] char: move QemuOpts->ChardevBackend translation to a separate func, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 02/13] char: add backend hotswap handler, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 03/13] char: chardevice hotswap, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 04/13] char: forbid direct chardevice access for hotswap devices, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 05/13] char: avoid chardevice direct access, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 06/13] test-char: unref chardev-udp after test, Anton Nefedov, 2017/05/30
- Re: [Qemu-devel] [PATCH v3 06/13] test-char: unref chardev-udp after test,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 09/13] test-char: add hotswap test, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 07/13] test-char: split char_udp_test, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 08/13] test-char: split char_file_test, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 12/13] serial: move TIOCM update to a separate function, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 10/13] hmp: add hmp analogue for qmp-chardev-change, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 11/13] virtio-console: chardev hotswap support, Anton Nefedov, 2017/05/30
- [Qemu-devel] [PATCH v3 13/13] serial: chardev hotswap support, Anton Nefedov, 2017/05/30