[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/12] hmp: Add hmp_announce_self
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 10/12] hmp: Add hmp_announce_self |
Date: |
Wed, 31 May 2017 10:47:20 +0100 |
User-agent: |
Mutt/1.8.2 (2017-04-18) |
* Vladislav Yasevich (address@hidden) wrote:
> Add an HMP command to trigger self annocements.
>
> Signend-off-by: Vladislav Yasevich <address@hidden>
^^
> ---
> hmp-commands.hx | 14 ++++++++++++++
> hmp.c | 5 +++++
> hmp.h | 1 +
> 3 files changed, 20 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index c8dd816..0efe479 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -939,6 +939,20 @@ Set the parameter @var{parameter} for GARP/RARP
> announcements.
> ETEXI
>
> {
> + .name = "qemu_announce_self",
> + .args_type = "",
> + .params = "",
> + .help = "Trigger GARP/RARP announcements",
> + .cmd = hmp_announce_self,
> + },
> +
> +STEXI
> address@hidden qemu_announce_self
> address@hidden qemu_announce_self
> +Trigger GARP/RARP announcements.
Yes, you could probably just call that 'announce_self';
if I understand then this version doesn't take any parameters
(unlike the qmp version) you just rely on the preset-configs.
That's OK if that mechanism stays the same.
Dave
> +ETEXI
> +
> + {
> .name = "migrate",
> .args_type = "detach:-d,blk:-b,inc:-i,uri:s",
> .params = "[-d] [-b] [-i] uri",
> diff --git a/hmp.c b/hmp.c
> index 7d41783..f3c1f02 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1509,6 +1509,11 @@ void hmp_announce_set_parameter(Monitor *mon, const
> QDict *qdict)
> }
> }
>
> +void hmp_announce_self(Monitor *mon, const QDict *qdict)
> +{
> + qmp_announce_self(false, NULL, NULL);
> +}
> +
> void hmp_migrate_cancel(Monitor *mon, const QDict *qdict)
> {
> qmp_migrate_cancel(NULL);
> diff --git a/hmp.h b/hmp.h
> index adf017c..fcb4be4 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -147,5 +147,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
> void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
> void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
> void hmp_info_announce_parameters(Monitor *mon, const QDict *qdict);
> +void hmp_announce_self(Monitor *mon, const QDict *qdict);
>
> #endif
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command, (continued)
- [Qemu-devel] [PATCH 07/12] migration: Allow for a limited number of announce timers, Vladislav Yasevich, 2017/05/24
- [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing, Vladislav Yasevich, 2017/05/24
- [Qemu-devel] [PATCH 10/12] hmp: Add hmp_announce_self, Vladislav Yasevich, 2017/05/24
- Re: [Qemu-devel] [PATCH 10/12] hmp: Add hmp_announce_self,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 09/12] hmp: add announce paraters info/set, Vladislav Yasevich, 2017/05/24
- [Qemu-devel] [PATCH 11/12] tests/test-hmp: Add announce parameter tests, Vladislav Yasevich, 2017/05/24
- [Qemu-devel] [PATCH 12/12] tests: Add a test for qemu self announcments, Vladislav Yasevich, 2017/05/24
- Re: [Qemu-devel] [PATCH 00/12] self-announce updates, no-reply, 2017/05/24
- Re: [Qemu-devel] [PATCH 00/12] self-announce updates, no-reply, 2017/05/24
- Re: [Qemu-devel] [PATCH 00/12] self-announce updates, no-reply, 2017/05/24
- Re: [Qemu-devel] [PATCH 00/12] self-announce updates, Dr. David Alan Gilbert, 2017/05/31