[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 5/6] migration: let MigrationState be an QOb
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH RFC 5/6] migration: let MigrationState be an QObject |
Date: |
Wed, 31 May 2017 15:33:04 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, May 30, 2017 at 05:57:44PM +0200, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > Let the old man "MigrationState" join the object family. Direct benefit
> > is that we can start to use all the property features derived from
> > current QObject, like: HW_COMPAT_* bits, command line setup for
> > migration parameters (so will never need to set them up each time using
> > HMP/QMP, this is really, really attractive for test writters), etc.
> >
> > I see no reason to disallow this happen yet. So let's start from this
> > one, to see whether it would be anything good.
> >
> > No functional change at all.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
>
> Please, send this patch in toplevel.
>
> Once there, as for following patch, could you incorporate as properties:
> - only_migratable: And we don't have to have the global variable in vl.c
> - global_state_set_optional()
> - savevm_skip_configuration()
> - savevm_skip_section_footers()
>
> So we don't have to export functions from them? they are just
> properties of this?
Okay. I'll try. :)
Thanks.
--
Peter Xu
Re: [Qemu-devel] [PATCH RFC 0/6] migration: enable return-path for precopy, Peter Xu, 2017/05/19