[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/22] Docker and block patches
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PULL 00/22] Docker and block patches |
Date: |
Tue, 30 May 2017 18:47:41 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, 05/30 11:36, Paolo Bonzini wrote:
>
>
> On 30/05/2017 11:33, Fam Zheng wrote:
> > On Tue, 05/30 10:19, Stefan Hajnoczi wrote:
> >> On Fri, May 26, 2017 at 03:52:24PM +0800, Fam Zheng wrote:
> >>> The following changes since commit
> >>> 9964e96dc9999cf7f7c936ee854a795415d19b60:
> >>>
> >>> Merge remote-tracking branch 'jasowang/tags/net-pull-request' into
> >>> staging (2017-05-23 15:01:31 +0100)
> >>>
> >>> are available in the git repository at:
> >>>
> >>> git://github.com/famz/qemu.git tags/docker-and-block-pull-request
> >>>
> >>> for you to fetch changes up to 77269bba94ef97de99ae61fdc98629a8704ae2ed:
> >>>
> >>> block: make accounting thread-safe (2017-05-26 09:25:30 +0800)
> >>>
> >>> ----------------------------------------------------------------
> >>>
> >>> For Paolo's block layer thread safety part I and my docker testing
> >>> enhancements.
> >>
> >> Please fix the checkpatch issues.
> >
> > Paolo, could you provide the comments that can be added to the memory
> > barriers?
>
> It's a false positive. The comments are just a couple lines above:
>
> /* We have to set low before high, just like stat64_max reads
> * high before low. The value may become lower temporarily, but
> * stat64_get does not notice (it takes the lock) and the only ill
> * effect on stat64_max is that the slow path may be triggered
> * unnecessarily.
> */
> atomic_set(&s->low, (uint32_t)value);
> smp_wmb();
> atomic_set(&s->high, value >> 32);
Ah okay, thanks!
Fam
- [Qemu-devel] [PULL 17/22] block: protect tracked_requests and flush_queue with reqs_lock, (continued)
- [Qemu-devel] [PULL 17/22] block: protect tracked_requests and flush_queue with reqs_lock, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 19/22] migration/block: reset dirty bitmap before reading, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 18/22] block: introduce dirty_bitmap_mutex, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 20/22] block: protect modification of dirty bitmaps with a mutex, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 21/22] block: introduce block_account_one_io, Fam Zheng, 2017/05/26
- [Qemu-devel] [PULL 22/22] block: make accounting thread-safe, Fam Zheng, 2017/05/26
- Re: [Qemu-devel] [PULL 00/22] Docker and block patches, no-reply, 2017/05/26
- Re: [Qemu-devel] [PULL 00/22] Docker and block patches, Stefan Hajnoczi, 2017/05/30