Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

[Paolo Bonzini]

> Note that a board that doesn't support MSI can take MSI-capable devices
> just fine.  Only the broken boards can't.
> 
> Obviously, broken boards should be fixed.  Once they all are, we can
> (and should!) remove msi_nonbroken.

That only works if we know what the broken boards are.

Right now, all boards that do not support MSI hide the capability, which
is wrong.  I'd prefer to remove msi_nonbroken completely if we don't
know where the problem is.

Paolo

> Ideally, the broken boards would mark themselves by clearing
> msi_nonbroken, with a comment explaining why.
> 
> Sadly, that's not what they do.  Instead, the *non-broken* boards mark
> themselves by setting msi_nonbroken.  Which ones of the boards that
> don't are actually broken is anyone's guess.  So is what exactly needs
> fixing.
> 
> I guess the first step towards removing msi_nonbroken would be
> addressing that particular sadness.  Patches welcome :)
>