qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/26] target/s390x: make IPTE SMP aware


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 02/26] target/s390x: make IPTE SMP aware
Date: Fri, 26 May 2017 06:53:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 05/25/2017 02:04 PM, Aurelien Jarno wrote:
      /* XXX we exploit the fact that Linux passes the exact virtual
         address here - it's not obliged to! */
-    tlb_flush_page(cs, page);
+    tlb_flush_page_all_cpus_synced(cs, page);
/* XXX 31-bit hack */
      if (page & 0x80000000) {
-        tlb_flush_page(cs, page & ~0x80000000);
+        tlb_flush_page_all_cpus_synced(cs, page & ~0x80000000);
      } else {
-        tlb_flush_page(cs, page | 0x80000000);
+        tlb_flush_page_all_cpus_synced(cs, page | 0x80000000);
      }

Ideally we would, at the same time, implement the local-pte facility, which examines a bit in the M4 field to *not* do this. That said,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]