[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new T
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock |
Date: |
Tue, 23 May 2017 17:56:15 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-23 12:48, Aurelien Jarno wrote:
> On 2017-05-22 20:02, Richard Henderson wrote:
> > Previously, helper_ex would construct the insn and then implement
> > the insn via direct calls other helpers. This was sufficient to
> > boot Linux but that is all.
> >
> > It is easy enough to go the whole nine yards by stashing state for
> > EXECUTE within the cpu, and then relying on a new TB to be created
> > that properly and completely interprets the insn.
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> > target/s390x/cpu.h | 4 +-
> > target/s390x/helper.h | 2 +-
> > target/s390x/insn-data.def | 4 +-
> > target/s390x/machine.c | 19 +++++++
> > target/s390x/mem_helper.c | 136
> > +++++++++++----------------------------------
> > target/s390x/translate.c | 124 +++++++++++++++++++++++++----------------
> > 6 files changed, 133 insertions(+), 156 deletions(-)
>
> This looks good on the principle, and finally removes a big hack. That
> said it prevent my test system to boot. I haven't investigated why yet.
This can aslo be reproduced using the kernel and initrd from the daily
Debian installer:
https://d-i.debian.org/daily-images/s390x/daily/generic/
I am personally using the following command line:
qemu-system-s390x -M s390-ccw-virtio -m 512 -nographic -kernel kernel.debian
-initrd initrd.debian
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net