[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validat
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/2] i386: rewrite way CPUID index is validated |
|
Date: |
Fri, 19 May 2017 16:43:12 -0300 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, May 19, 2017 at 04:58:23PM +0200, Kashyap Chamarthy wrote:
> On Tue, May 09, 2017 at 02:27:35PM +0100, Daniel P. Berrange wrote:
> > Change the nested if statements into a flat format, to make
> > it clearer what validation / capping is being performed on
> > different CPUID index values.
> >
> > NB this changes behaviour when "index > env->cpuid_xlevel2".
> > This won't have any guest-visible effect because no there is
> > no CPUID[0xC0000001]
>
> Nit: When applying, maybe the maintainer could fix the typo:
>
> "because no there is no" -> "because there is no"
This was already merged, unfortunately. Thanks for noting that,
anyway.
--
Eduardo