Re: [Qemu-devel] [Qemu-ppc] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

[Greg Kurz]

On Wed, 17 May 2017 16:37:52 +1000
David Gibson <address@hidden> wrote:
[...]
> > >>
> > >> Greg is looking at re-adding the ICPState array because of a 
> > >> migration issue with older machines. We might need to do so 
> > >> unconditionally ...
> > >>  
> > > 
> > > That would be a pity to carry on with the pre-allocated ICPStates for
> > > new machine types just because of that... What about keeping track
> > > of all the cap_irq_xics_enabled flags in a separate max_cpus sized
> > > static array ?  
> > 
> > Could we use 'cpu->unplug' instead ?  
> 
> I've only half followed this discussion, but fwiw I prefer the idea of
> "parking" in-kernel ICP objects, similarly to the way we do for
> removed VCPUs, rather than going back to keeping ICP objects around
> indefinitely and unconditionally.
> 

I'll give a try.

Cheers,

--
Greg

pgpx7X9xyR3FM.pgp
Description: OpenPGP digital signature