[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command |
Date: |
Mon, 15 May 2017 12:49:59 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/15/2017 11:47 AM, Daniel P. Berrange wrote:
> The '--image-opts' flag indicates whether the source filename
> includes options. The target filename has to remain in the
> plain filename format though, since it needs to be passed to
> bdrv_create(). When using --skip-create though, it would be
> possible to use image-opts syntax. This adds --target-image-opts
> to indicate that the target filename includes options. Currently
> this mandates use of the --skip-create flag too.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> qemu-img-cmds.hx | 4 +--
> qemu-img.c | 84
> ++++++++++++++++++++++++++++++++++++++------------------
> qemu-img.texi | 12 ++++++--
> 3 files changed, 69 insertions(+), 31 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v10 0/4] Improve convert and dd commands, Daniel P. Berrange, 2017/05/15
- [Qemu-devel] [PATCH v10 1/4] qemu-img: add support for --object with 'dd' command, Daniel P. Berrange, 2017/05/15
- [Qemu-devel] [PATCH v10 2/4] qemu-img: fix --image-opts usage with dd command, Daniel P. Berrange, 2017/05/15
- [Qemu-devel] [PATCH v10 4/4] qemu-img: copy *key-secret opts when opening newly created files, Daniel P. Berrange, 2017/05/15
- [Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command, Daniel P. Berrange, 2017/05/15
- Re: [Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v10 0/4] Improve convert and dd commands, Max Reitz, 2017/05/15