[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for sh
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable |
Date: |
Mon, 15 May 2017 11:41:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> wrote:
> On 05/11/2017 11:32 AM, Juan Quintela wrote:
>> Those two capabilities were added through the command line. Notice that
>> we just created them. This is just the boilerplate.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>>
>> --
>>
>> Make migrate_set_block_* take a boolean argument.
>
> Question - do we support the orthogonal selection of all 4 combinations
> under HMP 'migrate' (no argument, -b alone, -i alone, -b and -i
> together), or are there only 3 actual states? If the latter, should we
> represent this as a single enum-valued property, rather than as two
> independent boolean properties?
{ 'enum': 'MigrationCapability',
'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram'] }
My understanding is that we can only have boolean capabilities here.
Or, how could we put a non-boolean capability?
There are three states as far as I can see.
Later, Juan.
- [Qemu-devel] [PATCH v2 0/3] Remove old MigrationParams, Juan Quintela, 2017/05/11
- [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/11
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Eric Blake, 2017/05/12
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable,
Juan Quintela <=
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Dr. David Alan Gilbert, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Eric Blake, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Markus Armbruster, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Markus Armbruster, 2017/05/16
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/15
[Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams, Juan Quintela, 2017/05/11