qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extra


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extract op
Date: Fri, 12 May 2017 20:50:53 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 05/12/2017 01:50 PM, Richard Henderson wrote:
On 05/11/2017 08:35 PM, Philippe Mathieu-Daudé wrote:
-    tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16);
-    tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff);
+    tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff);

So your new script didn't work then?  This should be "..., 16, 16);".

Yeah this is wrong :(

I hope I got it in the last patchset (v4).

Thank for the review,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]