[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract() |
Date: |
Thu, 11 May 2017 11:03:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Ok I just understood Richard explanation, so this patch is WRONG and I
> need to get some real rest :(
Ha! Get some sleep; we'll still be around in the morning ;)
> On 05/10/2017 08:52 PM, Philippe Mathieu-Daudé wrote:
>> Apply this script using:
>>
>> $ docker run -v `pwd`:`pwd` -w `pwd` petersenna/coccinelle \
>> --sp-file scripts/coccinelle/tcg_gen_extract.cocci \
>> --macro-file scripts/cocci-macro-file.h \
>> --dir target \
>> --in-place
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>
>> This is a new version of the coccinelle script addressing Richard comments
>> and
>> trying to do it correctly. Also changed license to GPLv2+.
>>
>> The first rule matches, it calls a python2 script that basically checks the
>> target_ulong is not overflowed: (msk << ofs) >> sizeof(target_ulong) == 0
>
> WRONG
[...]
Is this script likely to be rerun in the future? If yes, keeping it in
scripts/coccinelle/ is a good idea. If no, I recommend to store it in
the commit message instead.
- [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() functions using extract op, Philippe Mathieu-Daudé, 2017/05/10
- [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/10
- Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Eric Blake, 2017/05/10
- Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Richard Henderson, 2017/05/10
- Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Eric Blake, 2017/05/10
- Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/10
- [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/10
- Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/10
- Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(),
Markus Armbruster <=
- Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/11
- Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Philippe Mathieu-Daudé, 2017/05/11
- Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract(), Markus Armbruster, 2017/05/15
[Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op, Philippe Mathieu-Daudé, 2017/05/10
[Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() using extract op, Philippe Mathieu-Daudé, 2017/05/10