[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate types |
Date: |
Wed, 10 May 2017 15:45:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> On Fri, May 05, 2017 at 03:53:40PM -0500, Eric Blake wrote:
[...]
>> Slightly simpler for ignoring int for now, while still something we
>> could add in later. I've been wanting to have an alternate for
>> 'int'/'str' for InetAddress port, since we want to support named ports
>> but most often use just integers. On the command line, port=1 is fine,
>> but in QMP, we currently have to spell it port="1". That's a case where
>> we'd allow a pairing of any string with an integer, rather than just an
>> enum.
>
> Does that mean we already have an use case where we will have to
> relax the restrictions on ambiguous enums? :)
A rather weak one. Certainly too weak by itself to make me open another
can of string-input-visitor worms.
> I won't mind at all if we remove the runtime detection of
> ambiguous enums. It will make the code much simpler.
That's the idea :)