[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for ina
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images |
Date: |
Thu, 4 May 2017 12:42:55 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/04/2017 11:52 AM, Kevin Wolf wrote:
> Format drivers for inactive nodes don't need write/resize permissions on
> their bs->file and can share write/resize with another VM (in fact, this
> is the whole point of keeping images inactive). Represent this fact in
> the op blocker system, so that image locking does the right thing
> without special-casing inactive images.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 35 +++++++++++++++++++++++++++++++++--
> include/block/block.h | 1 +
> 2 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 773bd64..cd89467 100644
> --- a/block.c
> +++ b/block.c
> @@ -192,11 +192,20 @@ void path_combine(char *dest, int dest_size,
> }
> }
>
> +/* Returns whether the image file is opened as read-only. Note that this can
> + * return false and writing to the image file is still not possible because
> the
s/false and/false but/
s/is still not/still not be/
> + * image is inactivated. */
> bool bdrv_is_read_only(BlockDriverState *bs)
> {
> return bs->read_only;
> }
>
> +/* Returns whether the image file can be written to right now */
> +bool bdrv_is_writable(BlockDriverState *bs)
> +{
> + return !bdrv_is_read_only(bs) && !(bs->open_flags & BDRV_O_INACTIVE);
> +}
Nice.
Up to you if you think the grammar suggestion helps.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 2/6] block: New BdrvChildRole.activate() for blk_resume_after_migration(), Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 3/6] block: Drop permissions when migration completes, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images, Kevin Wolf, 2017/05/04
- Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images,
Eric Blake <=
- [Qemu-devel] [PATCH 6/6] file-posix: Remove .bdrv_inactivate/invalidate_cache, Kevin Wolf, 2017/05/04
- Re: [Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images, Kevin Wolf, 2017/05/09