Re: [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2e434a9 qmp-shell: improve help
77cd9f0 qmp-shell: don't show version greeting if unavailable
d17e4fb qmp-shell: Cope with query-commands error
f7ac3c4 qmp-shell: add -N option to skip negotiate
9571758 qmp-shell: add persistent command history
aa00985 qobject-input-visitor: Catch misuse of end_struct vs. end_list
194b3e2 qapi: Document intended use of @name within alternate visits
67c0090 qobject-input-visitor: Document full_name_nth()
8c16783 qmp: Improve QMP dispatch error messages
a0442d2 sockets: Delete unused helper socket_address_crumple()
ca90b03 sockets: Limit SocketAddressLegacy to external interfaces
40d5602 sockets: Rename SocketAddressFlat to SocketAddress
f8b9bbb sockets: Rename SocketAddress to SocketAddressLegacy
a81dc52 qapi: New QAPI_CLONE_MEMBERS()
4f18471 sockets: Prepare inet_parse() for flattened SocketAddress
5cbeffc sockets: Prepare vsock_parse() for flattened SocketAddress
cc90aaf test-qga: Actually test 0xff sync bytes
df3003f fdc-test: Avoid deprecated 'change' command
e502932 QemuOpts: Simplify qemu_opts_to_qdict()
a972d47 block: Simplify bdrv_append_temp_snapshot() logic
2734767 qobject: Use simpler QDict/QList scalar insertion macros
c22a7a9 qobject: Add helper macros for common scalar insertions
c756d1f qobject: Drop useless QObject casts
6382ef6 coccinelle: Add script to remove useless QObject casts
1ee7cad pci: Reduce scope of error injection
c49aaf2 pci: Use struct instead of QDict to pass back parameters
8539934 test-keyval: fix leaks
d12b2b3 tests/check-qdict: Fix missing brackets

=== OUTPUT BEGIN ===
Checking PATCH 1/28: tests/check-qdict: Fix missing brackets...
Checking PATCH 2/28: test-keyval: fix leaks...
Checking PATCH 3/28: pci: Use struct instead of QDict to pass back parameters...
Checking PATCH 4/28: pci: Reduce scope of error injection...
Checking PATCH 5/28: coccinelle: Add script to remove useless QObject casts...
Checking PATCH 6/28: qobject: Drop useless QObject casts...
Checking PATCH 7/28: qobject: Add helper macros for common scalar insertions...
Checking PATCH 8/28: qobject: Use simpler QDict/QList scalar insertion macros...
Checking PATCH 9/28: block: Simplify bdrv_append_temp_snapshot() logic...
Checking PATCH 10/28: QemuOpts: Simplify qemu_opts_to_qdict()...
Checking PATCH 11/28: fdc-test: Avoid deprecated 'change' command...
Checking PATCH 12/28: test-qga: Actually test 0xff sync bytes...
ERROR: trailing whitespace
#89: FILE: tests/test-qga.c:159:
+     * 'id' field of the response does not match the 'id' field of $

total: 1 errors, 0 warnings, 70 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/28: sockets: Prepare vsock_parse() for flattened 
SocketAddress...
Checking PATCH 14/28: sockets: Prepare inet_parse() for flattened 
SocketAddress...
Checking PATCH 15/28: qapi: New QAPI_CLONE_MEMBERS()...
Checking PATCH 16/28: sockets: Rename SocketAddress to SocketAddressLegacy...
WARNING: line over 80 characters
#129: FILE: blockdev-nbd.c:127:
+        /* TODO SOCKET_ADDRESS_LEGACY_KIND_FD where fd has AF_INET or AF_INET6 
*/

WARNING: line over 80 characters
#525: FILE: include/qemu/sockets.h:49:
+int socket_connect(SocketAddressLegacy *addr, NonBlockingConnectHandler 
*callback,

WARNING: line over 80 characters
#531: FILE: include/qemu/sockets.h:53:
+int socket_dgram(SocketAddressLegacy *remote, SocketAddressLegacy *local, 
Error **errp);

WARNING: line over 80 characters
#918: FILE: migration/socket.c:28:
+static SocketAddressLegacy *tcp_build_address(const char *host_port, Error 
**errp)

WARNING: line over 80 characters
#1727: FILE: ui/vnc.c:3613:
+        *retwsaddr = g_renew(SocketAddressLegacy *, *retwsaddr, *retnwsaddr + 
1);

WARNING: line over 80 characters
#1887: FILE: util/qemu-sockets.c:1075:
+int socket_connect(SocketAddressLegacy *addr, NonBlockingConnectHandler 
*callback,

WARNING: line over 80 characters
#1970: FILE: util/qemu-sockets.c:1152:
+int socket_dgram(SocketAddressLegacy *remote, SocketAddressLegacy *local, 
Error **errp)

total: 0 errors, 7 warnings, 1895 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 17/28: sockets: Rename SocketAddressFlat to SocketAddress...
Checking PATCH 18/28: sockets: Limit SocketAddressLegacy to external 
interfaces...
Checking PATCH 19/28: sockets: Delete unused helper socket_address_crumple()...
Checking PATCH 20/28: qmp: Improve QMP dispatch error messages...
Checking PATCH 21/28: qobject-input-visitor: Document full_name_nth()...
Checking PATCH 22/28: qapi: Document intended use of @name within alternate 
visits...
Checking PATCH 23/28: qobject-input-visitor: Catch misuse of end_struct vs. 
end_list...
Checking PATCH 24/28: qmp-shell: add persistent command history...
Checking PATCH 25/28: qmp-shell: add -N option to skip negotiate...
Checking PATCH 26/28: qmp-shell: Cope with query-commands error...
Checking PATCH 27/28: qmp-shell: don't show version greeting if unavailable...
Checking PATCH 28/28: qmp-shell: improve help...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden