Re: [Qemu-devel] [Qemu-block] [PATCH 08/17] throttle-groups: protect throttled requests with a CoMutex

[Stefan Hajnoczi]

On Thu, May 04, 2017 at 02:57:48PM +0800, Fam Zheng wrote:
> On Thu, 04/20 14:00, Paolo Bonzini wrote:
> > diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
> > index 87a43b0..e9529fb 100644
> > --- a/include/sysemu/block-backend.h
> > +++ b/include/sysemu/block-backend.h
> > @@ -72,11 +72,8 @@ typedef struct BlockDevOps {
> >   * fields that must be public. This is in particular for QLIST_ENTRY() and
> >   * friends so that BlockBackends can be kept in lists outside 
> > block-backend.c */
> >  typedef struct BlockBackendPublic {
> > -    /* I/O throttling has its own locking, but also some fields are
> > -     * protected by the AioContext lock.
> > -     */
> > -
> > -    /* Protected by AioContext lock.  */
> > +    /* reqs_lock protects the CoQueues for throttled requests.  */
> > +    CoMutex      reqs_lock;
> 
> Bikeshedding: will it be more readable if it's called throttled_reqs_lock or
> throttled_lock?

Yes, please.

Stefan

signature.asc
Description: PGP signature